Rodney Joyce
Posts:123
 |
| 07/12/2008 7:30 PM |
|
Hi Pengtsen,
I noticed a lot of these errors in my Event Log: should I be worried about them? It looks like the Google bot is causing it...
ModuleId: 2038
ModuleDefId: 302
FriendlyName: Poker Video List
ModuleControlSource: DesktopModules/UltraVideoGallery/VideoList.ascx
AssemblyVersion: 04.08.02
PortalID: 6
PortalName: PokerDIY
UserID: -1
UserName:
ActiveTabID: 484
ActiveTabName: Poker Videos
RawURL: /watch-poker-videos/PokerVideoSearchResults/TagId/95.aspx
AbsoluteURL: /Default.aspx
AbsoluteURLReferrer:
UserAgent: Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)
DefaultDataProvider: DotNetNuke.Data.SqlDataProvider, DotNetNuke.SqlDataProvider
ExceptionGUID: be011e53-be81-4709-ac69-cf6f8243f45c
InnerException: Object reference not set to an instance of an object.
FileName:
FileLineNumber: 0
FileColumnNumber: 0
Method: BizModules.UltraVideoGallery.ucPagerControl.GotoPage
StackTrace:
Message:
DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference
not set to an instance of an object. --->
System.NullReferenceException: Object reference not set to an instance
of an object. at
BizModules.UltraVideoGallery.ucPagerControl.GotoPage(Int32 intPage) at
BizModules.UltraVideoGallery.ucPagerControl.BindData() at
BizModules.UltraVideoGallery.ucPagerControl.set_TotalPages(Int32 Value)
at BizModules.UltraVideoGallery.VideoList.BindData() at
BizModules.UltraVideoGallery.VideoList.Page_Load(Object sender,
EventArgs e) --- End of inner exception stack trace ---
Source:
Server Name: DEDI180 |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 07/13/2008 6:38 AM |
|
| I didn't hear about this problem before, do you know how to fire it in your UVG listing module? |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 07/30/2008 10:47 PM |
|
Sorry, got side-tracked!
I can now reproduce this issue as it causes an issue on my poker videos page.
Go to this page and click on any of the poker video categories on the right.
An error occurs (ie. "Error: Poker Video List is currently unavailable.") and this error is logged. I THINK it may have only started happening after I installed URL Master but not 100% sure.
ModuleId: 2038
ModuleDefId: 302
FriendlyName: Poker Video List
ModuleControlSource: DesktopModules/UltraVideoGallery/VideoList.ascx
AssemblyVersion: 04.08.02
PortalID: 6
PortalName: PokerDIY
UserID: 1
UserName: rod
ActiveTabID: 484
ActiveTabName: Poker Videos
RawURL: /watch-poker-videos/CategoryId/9/Poker-Babes.aspx
AbsoluteURL: /Default.aspx
AbsoluteURLReferrer: http://www.pokerdiy.com/watch-poker-videos/CategoryId/5/Funny-Poker-Vids.aspx
UserAgent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
DefaultDataProvider: DotNetNuke.Data.SqlDataProvider, DotNetNuke.SqlDataProvider
ExceptionGUID: 8910059b-1811-4461-bd7f-3f4f6191c0e3
InnerException: Object reference not set to an instance of an object.
FileName:
FileLineNumber: 0
FileColumnNumber: 0
Method: BizModules.UltraVideoGallery.ucPagerControl.GotoPage
StackTrace:
Message:
DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference
not set to an instance of an object. --->
System.NullReferenceException: Object reference not set to an instance
of an object. at
BizModules.UltraVideoGallery.ucPagerControl.GotoPage(Int32 intPage) at
BizModules.UltraVideoGallery.ucPagerControl.BindData() at
BizModules.UltraVideoGallery.ucPagerControl.set_TotalPages(Int32 Value)
at BizModules.UltraVideoGallery.VideoList.BindData() at
BizModules.UltraVideoGallery.VideoList.Page_Load(Object sender,
EventArgs e) --- End of inner exception stack trace ---
Source:
Server Name: DEDI180
|
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 07/31/2008 2:02 AM |
|
since I didn't hear about this problem before, I guess it is fired by url master, please disable it and try again, if this error fixed after disable url master, contact the author to see if the querystring is properly converted to friendly format.
thanks. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/05/2008 11:22 PM |
|
| Ok, when I disable UM the page works. I am sending this information to Bruce of Ifinity to see if he can work out the problem. |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Rodney Joyce
Posts:123
|
| 08/06/2008 5:20 AM |
|
Pengtsen, could you please post the code from the method "ucPagerControl.GotoPage(Int32 intPage)"?
Bruce does not have any ideas what it could be - the URL is missing the TabID but we are a bit stuck. |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/06/2008 5:36 AM |
|
ok, not a problem the code is here:
Public Function GotoPage(ByVal intPage As Integer) As String
Dim strQueryString As String = ""
For i As Integer = 0 To Request.QueryString.AllKeys.Length - 1
Dim strKey As String = Request.QueryString.AllKeys(i).ToString()
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
If strKey.ToLower = "page" Then
strQueryString = strQueryString + "page" + "/" + intPage.ToString
ElseIf strKey.ToLower = "type" Then
strQueryString = strQueryString + "type" + "/" + OrderType.ToString
ElseIf strKey.ToLower <> "tabid" Then
strQueryString = strQueryString + strKey + "/" + Request.QueryString(strKey)
ElseIf strKey.ToLower = "tagid" Then
strQueryString = strQueryString + strKey + "/" + Request.QueryString(strKey)
End If
Next
If strQueryString.ToLower.IndexOf("page") < 0 Then
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
strQueryString = strQueryString + "Page/" + intPage.ToString
End If
If strQueryString.ToLower.IndexOf("type") < 0 Then
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
strQueryString = strQueryString + "type/" + OrderType.ToString
End If
If CategoryId > 0 Then
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
strQueryString = strQueryString + "categoryId/" + CategoryId.ToString
End If
If Request.QueryString("Tag") <> "" Then
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
strQueryString = strQueryString + "Tag/" + Request.QueryString("Tag")
End If
If Request.QueryString("Search") <> "" Then
If strQueryString <> "" Then
strQueryString = strQueryString + "/"
End If
strQueryString = strQueryString + "Search/" + Request.QueryString("Search")
End If
Return NavigateURL(TabId, "", strQueryString)
End Function
|
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/06/2008 6:53 AM |
|
| Thanks for that. Interestingly, I set this up on my localhost site and the error did NOT occur with the latest version of UM and UVG 2.0 - as soon as I upgraded to UVG 2.4.2 the error started occurring locally as well. Has this method changed in between those versions? |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/06/2008 4:46 PM |
|
| The last modified date of ucPagerControl.ascx.vb is 2008-3-8, at that time the UVG version should be 2.2.x. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/06/2008 7:27 PM |
|
Hi Pengtsen, here are some comments from Bruce:
"
However, I think I've spotted the problem
Doing a debug with Fiddler on that page, I get the following information
out:
X-UrlMaster-Debug:
http://www.pokerdiy.com/watch-poker-videos/CategoryId/5/Funny-Poker-Vids
.aspx, , Default.aspx?tabId=484&categoryid=5&funny-poker-vids, Continue
Where the items (separated by commas) are:
Original Url as requested
Redirect url (blank as no redirect)
Rewritten Url (as Pengsten's code would see it) Internal Url Master action : (Continue == OK, return 200)
The only thing I can possibly think of at this stage is that the &funny-poker-vids returns a null reference because he makes the assumption that every key/value pair in the querystring will have both a key and a value. It's perfectly allowed within the query string collection to have a key with no associated value
(key1=&key2=value) or for a value without a key (&value). In the case of a value w/out a key, you'll get a null value for the key when you request it from the collection.
I think the correct fix for the posted code is to insert a 'null check'
around the code that iterates the query string collection:
Dim strKey As String = Request.QueryString.AllKeys(i).ToString()
If not strKey is Nothing Then
If strQueryString <> "" Then
'.... As before
End If
End if
The reason it fails after the Url Master module is used, is because the Url Master module puts the 'friendly' section of the Url on the back of the querystring collection. This is because it uses a position-based approach to reconstructing the query string from the original Url. The base DNN Provider 'knows' which is the page name based on the regex patterns in siteurls.config, so wouldn't put the 'friendly name' on the end of the querystring. Without a tabid/xx string in the middle of the Url, the Url Master code doesn't know where the page name stops and the querystring path begins, so has to do 'best guess' on this basis. It's complicated but I'm sure you get the drift. The point is, it's not illegal to have a query string value with a null key, and the code should allow for that.
"
Looking at your code (where it loops through the querystring keys) - could this be the problem? |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/07/2008 6:44 AM |
|
Rodney, so you get this problem in UVG 2.4.2, right?
what's the url of the page you get this problem, I want to know the url when UM is enabled AND disabled. so I can compare them. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/07/2008 7:24 AM |
|
Yes, version 2.4.2.
The problem occurs on my poker videos page, and when I turn off UM it works with this URL,
http://www.pokerdiy.com/PokerVideos/TabId/484/CategoryId/5/Funny-Poker-Vids.aspx
but this one causes an error:
http://www.pokerdiy.com/watch-poker-videos/CategoryId/5/Funny-Poker-Vids.aspx
http://www.pokerdiy.com/PokerVideos/tabid/484/Default.aspx (video page)
|
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/08/2008 2:23 AM |
|
| I'll contact bruce and give you further reply. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/09/2008 7:29 PM |
|
| Ok, please keep me informed |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/10/2008 7:24 PM |
|
| it seems bruce is right, however, I still doesn't know why there is a null key in querystring. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/10/2008 9:11 PM |
|
| Yes, the latest update seemed to fix! Thanks for the quick response - out of interest, what did you change (so I know for my modules) |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/11/2008 6:44 AM |
|
as bruce suggested.
it seems the querystring rewrote by UM contains a null key. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/25/2008 2:08 AM |
|
Hi Pengtsen
I am getting a lot of errors in my event viewer (http://www.pokerdiy.com/ /search-poker-videos/tagid/182/page/4/type/mostrecent.aspx) - I am not sure if this is a related error:
ModuleId: 2051
ModuleDefId: 302
FriendlyName: Poker Video Search Results
ModuleControlSource: DesktopModules/UltraVideoGallery/VideoList.ascx
AssemblyVersion: 04.08.02
PortalID: 6
PortalName: PokerDIY
UserID: -1
UserName:
ActiveTabID: 567
ActiveTabName: Poker Video Search Results
RawURL: /search-poker-videos/tagid/182/page/4/type/mostrecent.aspx
AbsoluteURL: /Default.aspx
AbsoluteURLReferrer:
UserAgent: Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)
DefaultDataProvider: DotNetNuke.Data.SqlDataProvider, DotNetNuke.SqlDataProvider
ExceptionGUID: f840ee06-f794-4f4a-90d6-0150fcd46cf2
InnerException: Requested value 'mostrecent' was not found.
FileName:
FileLineNumber: 0
FileColumnNumber: 0
Method: System.Enum.Parse
StackTrace:
Message:
DotNetNuke.Services.Exceptions.ModuleLoadException: Requested value
'mostrecent' was not found. ---> System.ArgumentException: Requested
value 'mostrecent' was not found. at System.Enum.Parse(Type enumType,
String value, Boolean ignoreCase) at
BizModules.UltraVideoGallery.VideoList.Page_Load(Object sender,
EventArgs e) --- End of inner exception stack trace ---
Source:
Server Name: DEDI180 |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|
Pengtsen R
Posts:11533
|
| 08/25/2008 5:52 AM |
|
| "'mostrecent' was not found" error is due to url master, "MostResent" is case-sensitive in UVG, but url master convert it to mostresent, so you should config url master to prevent this. |
|
Pengtsen R
http://www.bizmodules.net |
|
|
Rodney Joyce
Posts:123
|
| 08/25/2008 6:15 AM |
|
Hmm - would it be possible to make it case-insensitive?
Basically in my Google Sitemaster Tools I have thousands of duplicate URLs that differ only in case, eg:
/poker-player-profile/id/2022.aspx
/poker-player-profile/ID/2022.aspx
are both indexed and flagged as Duplicate Data. Hence I use URLMaster to change ALL Urls (I have over 500 duplicate content issues in Google due to different case) to lowercase. It is a setting in his module and I would prefer to keep them all lowercase to prevent duplicate data issues.
Would it be possible to change in a later version please? |
|
Thanks
Rodney
PokerDIY - Free poker leagues |
|
|